Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean-up metric testing #4059

Closed
Borda opened this issue Oct 10, 2020 · 2 comments · Fixed by #4122 or #4152
Closed

clean-up metric testing #4059

Borda opened this issue Oct 10, 2020 · 2 comments · Fixed by #4122 or #4152
Assignees
@Borda
Labels
ci Continuous Integration feature Is an improvement or enhancement

Comments

@Borda
Copy link
Member

Borda commented Oct 10, 2020

🚀 Feature

apply comments in #4043 which were ignored and make the tests easier too understand

Motivation

now the testing so black-boxing, and confusing with the same function SK names in different files
@Borda Borda added feature Is an improvement or enhancement ci Continuous Integration labels Oct 10, 2020
@Borda Borda self-assigned this Oct 10, 2020
@awaelchli
Copy link
Contributor

and also very important, we need to speed it up. The ddp initialization and forking processes causes tests to run several minutes.

@SkafteNicki SkafteNicki mentioned this issue Oct 13, 2020
Merged
7 tasks
@Borda
Copy link
Member Author

Borda commented Oct 14, 2020

cleaning in #4152

@Borda Borda reopened this Oct 14, 2020
@Borda Borda mentioned this issue Oct 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Borda Borda

Labels
ci Continuous Integration feature Is an improvement or enhancement
Projects
None yet
Milestone
No milestone
2 participants
@awaelchli @Borda