-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dead Links in "Implementing your own DDP" documentation #5031
Labels
Comments
Hi! thanks for your contribution!, great first issue! |
alanhdu
changed the title
Outdated documentation
Outdated documentation for "Implementing your own DDP"
Dec 8, 2020
alanhdu
changed the title
Outdated documentation for "Implementing your own DDP"
Dead Links in "Implementing your own DDP" documentation
Dec 8, 2020
@alanhdu mind send a PR? |
@Borda -- what should the updated links point to? Presumably the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📚 Documentation
In the "Implementing your own DDP section" (https://pytorch-lightning.readthedocs.io/en/stable/multi_gpu.html#implement-your-own-distributed-ddp-training), the text says:
Unfortunately, both of those seem to be dead links. I'm not sure what would replace them -- the custom DDP implementation should presumably point to https://pytorch-lightning.readthedocs.io/en/stable/accelerators.html#implement-a-custom-accelerator, but I'm not sure where the "overriding the init Pytorch DDP" should live (from the Git blame, it looks like used to call to a
init_ddp_connection
function that doesn't seem to exist anymore).The text was updated successfully, but these errors were encountered: