Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arbitrary val check intervals when using max_steps #6061

Closed
monney opened this issue Feb 18, 2021 · 1 comment
Closed

Allow arbitrary val check intervals when using max_steps #6061

monney opened this issue Feb 18, 2021 · 1 comment
Labels
feature Is an improvement or enhancement help wanted Open to be worked on

Comments

@monney
Copy link
Contributor

monney commented Feb 18, 2021

🚀 Feature

Currently when using the max epochs setting we can set val_check_interval to any arbitrary value we like. We cannot do this if max_steps is set. It must be less than one epoch.

Motivation

Constraining this value to be determined as a number of steps and also be less than an epoch makes it difficult to configure this value ahead of runtime, because an epoch length depends on many different factors. I usually use max_steps to easily configure schedulers and such that are stepped on a per batch basis, it allows values to be set before runtime in a portable way.

Pitch

allow this value to be any step count independent of epochs.

Alternatives

allow it to be defined a multiplier as when max_epochs is used

@monney monney added feature Is an improvement or enhancement help wanted Open to be worked on labels Feb 18, 2021
@monney
Copy link
Contributor Author

monney commented Feb 24, 2021

Was used old API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement help wanted Open to be worked on
Projects
None yet
Development

No branches or pull requests

1 participant