-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract dataset definition out of the LightningModule #662
Labels
Comments
cgarciae
added
feature
Is an improvement or enhancement
help wanted
Open to be worked on
labels
Jan 4, 2020
Why not allow for both? add 3 args to trainer or do it in .fit(). if any of these datasets are passed in the corresponding lightningModule class isn’t called. thoughts? |
@cgarciae want to submit this PR? i agree that we should allow both ways of doing it |
@cgarciae can the issue be closed or is there something left to do? |
Looks awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🚀 Feature
Extract dataset definition out of the
LightningModule
Motivation
Separation of data from the model.
Pitch
The datasets loaders could easily be passed to the
fit
method directly instead of having to define them inside theLightningModule
, this avoids having a single class that possibly contains: data, data pipeline params, model, model hyperparams.The basic example cloud look like this:
Its much more natural to how you usually structure your code in
scikit-learn
orkeras
.Alternatives
They could also be based to the
Trainer
s constructor.The text was updated successfully, but these errors were encountered: