Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prepare_data call for downloading datasets #928

Closed
williamFalcon opened this issue Feb 24, 2020 · 0 comments · Fixed by #926
Closed

Add prepare_data call for downloading datasets #928

williamFalcon opened this issue Feb 24, 2020 · 0 comments · Fixed by #926
Assignees
@williamFalcon
Labels
feature Is an improvement or enhancement help wanted Open to be worked on

Comments

@williamFalcon
Copy link
Contributor

williamFalcon commented Feb 24, 2020 •
edited
Loading

🚀 Feature

Data download and loading data should be separate because it causes issues on distributed environments.

Add

def prepare_data(self):
   # download and prep the data

def train_dataloader(self):
   # create dataloader
@williamFalcon williamFalcon added feature Is an improvement or enhancement help wanted Open to be worked on labels Feb 24, 2020
@williamFalcon williamFalcon self-assigned this Feb 24, 2020
@williamFalcon williamFalcon mentioned this issue Feb 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamFalcon williamFalcon

Labels
feature Is an improvement or enhancement help wanted Open to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up dataloader logic Lightning-AI/pytorch-lightning
1 participant
@williamFalcon