Fail the test when a `DeprecationWarning` is raised #9939

carmocca · 2021-10-15T02:10:47Z

Proposed refactoring or deprecation

Set our test suite to fail when a DeprecationWarning is raised.

Motivation

Since we don't track warnings raised by our tests, it's too easy to introduce a deprecation path but forget to update all deprecated usages inside our codebase and tests.

This is very bad in terms of UX because the users will see this warning appear but won't be able to do anything to fix it.

This has been exacerbated lately with the number of deprecations happening.

For example consider this simple training script:

import torch
from torch.utils.data import DataLoader, Dataset

from pytorch_lightning import LightningModule, Trainer, LightningDataModule


class RandomDataset(Dataset):
    def __init__(self, size, length):
        self.len = length
        self.data = torch.randn(length, size)

    def __getitem__(self, index):
        return self.data[index]

    def __len__(self):
        return self.len


class BoringModel(LightningModule):
    def __init__(self):
        super().__init__()
        self.layer = torch.nn.Linear(32, 2)

    def forward(self, x):
        return self.layer(x)

    def training_step(self, batch, batch_idx):
        loss = self(batch).sum()
        self.log("train_loss", loss)
        return {"loss": loss}

    def validation_step(self, batch, batch_idx):
        loss = self(batch).sum()
        self.log("valid_loss", loss)

    def test_step(self, batch, batch_idx):
        loss = self(batch).sum()
        self.log("test_loss", loss)

    def configure_optimizers(self):
        return torch.optim.SGD(self.layer.parameters(), lr=0.1)


class BoringDataModule(LightningDataModule):
    def train_dataloader(self):
        return DataLoader(RandomDataset(32, 64), batch_size=2)

    def val_dataloader(self):
        return DataLoader(RandomDataset(32, 64), batch_size=2)

    def test_dataloader(self):
        return DataLoader(RandomDataset(32, 64), batch_size=2)

    def predict_dataloader(self):
        return DataLoader(RandomDataset(32, 64), batch_size=2)


def run():
    model = BoringModel()
    datamodule = BoringDataModule()
    trainer = Trainer(
        limit_train_batches=1,
        limit_val_batches=1,
        limit_test_batches=1,
        limit_predict_batches=1,
        max_epochs=1,
    )
    trainer.fit(model, datamodule)
    trainer.test(verbose=False)
    trainer.predict()


if __name__ == "__main__":
    run()

Deprecation warnings in 1.4.9:

pytorch_lightning/core/datamodule.py:423: LightningDeprecationWarning: DataModule.prepare_data has already been called, so it will not be called again. In v1.6 this behavior will change to always call DataModule.prepare_data.

Deprecation warnings in current master:

pytorch_lightning/accelerators/accelerator.py:590: LightningDeprecationWarning: `Accelerator.on_validation_start` is deprecated in v1.5 and will be removed in v1.6. `on_validation_start` logic is implemented directly in the `TrainingTypePlugin` implementations.
pytorch_lightning/accelerators/accelerator.py:295: LightningDeprecationWarning: `Accelerator.validation_step_end` is deprecated in v1.5 and will be removed in v1.6. `validation_step_end` logic is implemented directly in the `TrainingTypePlugin` implementations.
pytorch_lightning/accelerators/accelerator.py:635: LightningDeprecationWarning: `Accelerator.on_validation_end` is deprecated in v1.5 and will be removed in v1.6. `on_validation_end` logic is implemented directly in the `TrainingTypePlugin` implementations.                                                                       
pytorch_lightning/accelerators/accelerator.py:696: LightningDeprecationWarning: `Accelerator.on_train_batch_start` is deprecated in v1.5 and will be removed in v1.6. `on_train_batch_start` logic is implemented directly in the `TrainingTypePlugin` implementations.
pytorch_lightning/accelerators/accelerator.py:263: LightningDeprecationWarning: `Accelerator.training_step_end` is deprecated in v1.5 and will be removed in v1.6. `training_step_end` logic is implemented directly in the `TrainingTypePlugin` implementations.
pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py:327: LightningDeprecationWarning: The property `LoggerConnector.gpus_metrics` was deprecated in v1.5 and will be removed in 1.7. Use the `DeviceStatsMonitor` callback instead.
pytorch_lightning/accelerators/accelerator.py:680: LightningDeprecationWarning: `Accelerator.on_train_end` is deprecated in v1.5 and will be removed in v1.6. `on_train_end` logic is implemented directly in the `TrainingTypePlugin` implementations.                                                                                 
pytorch_lightning/accelerators/accelerator.py:605: LightningDeprecationWarning: `Accelerator.on_test_start` is deprecated in v1.5 and will be removed in v1.6. `on_test_start` logic is implemented directly in the `TrainingTypePlugin` implementations.
pytorch_lightning/accelerators/accelerator.py:279: LightningDeprecationWarning: `Accelerator.test_step_end` is deprecated in v1.5 and will be removed in v1.6. `test_step_end` logic is implemented directly in the `TrainingTypePlugin` implementations.
pytorch_lightning/accelerators/accelerator.py:650: LightningDeprecationWarning: `Accelerator.on_test_end` is deprecated in v1.5 and will be removed in v1.6. `on_test_end` logic is implemented directly in the `TrainingTypePlugin` implementations.
pytorch_lightning/accelerators/accelerator.py:620: LightningDeprecationWarning: `Accelerator.on_predict_start` is deprecated in v1.5 and will be removed in v1.6. `on_predict_start` logic is implemented directly in the `TrainingTypePlugin` implementations.
pytorch_lightning/accelerators/accelerator.py:665: LightningDeprecationWarning: `Accelerator.on_predict_end` is deprecated in v1.5 and will be removed in v1.6. `on_predict_end` logic is implemented directly in the `TrainingTypePlugin` implementations.

Pitch

Set

filterwarnings =
    # error out on deprecation warnings - ensures the code and tests are kept up-to-date
    error::DeprecationWarning
    # TensorBoard is using NumPy deprecations: ignore them
    ignore::DeprecationWarning:tensorboard.*

in https://github.com/PyTorchLightning/pytorch-lightning/blob/16213b16356f5bd97b8cc8bf1849eacd68d658c5/setup.cfg#L15-L27

and fill all deprecated usages. This will need to be done over several PRs

If the test writer actually wants to test that a deprecation is raised, pytest.deprecated_call(...) will need to be used to catch it.

If you enjoy Lightning, check out our other projects! ⚡

_{Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, finetuning and solving problems with deep learning

Bolts: Pretrained SOTA Deep Learning models, callbacks and more for research and production with PyTorch Lightning and PyTorch

Lightning Transformers: Flexible interface for high performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.}

The text was updated successfully, but these errors were encountered:

daniellepintz · 2021-10-15T04:31:20Z

GREAT proposal, completely agree!

carmocca · 2021-10-15T17:07:23Z

There are many many occurrences to update, anybody who wants to help is welcome to do so!

daniellepintz · 2021-10-17T00:19:55Z

@carmocca are you doing this file by file, or some other way? Do you have a list of files you have already done/or ones that need to be done so that we can help?

carmocca · 2021-10-18T01:24:31Z

We can do it file by file or semantically (all occurrences of a deprecation) - up to you.

You can check the current azure CI job status on the main PR (#9940) to see which test are still failing.

Currently 185:

tests/accelerators/test_accelerator_connector.py::test_accelerator_choice_ddp_slurm
tests/accelerators/test_accelerator_connector.py::test_accelerator_choice_ddp2_slurm
tests/accelerators/test_accelerator_connector.py::test_accelerator_choice_ddp_te
tests/accelerators/test_accelerator_connector.py::test_accelerator_choice_ddp2_te
tests/accelerators/test_accelerator_connector.py::test_accelerator_choice_ddp_kubeflow
tests/accelerators/test_cpu.py::test_plugin_setup_optimizers_in_pre_dispatch[True]
tests/accelerators/test_cpu.py::test_plugin_setup_optimizers_in_pre_dispatch[False]
tests/callbacks/test_gpu_stats_monitor.py::test_gpu_stats_monitor - py...
tests/callbacks/test_gpu_stats_monitor.py::test_gpu_stats_monitor_no_queries
tests/callbacks/test_gpu_stats_monitor.py::test_gpu_stats_monitor_no_logger
tests/callbacks/test_gpu_stats_monitor.py::test_gpu_stats_monitor_no_gpu_warning
tests/callbacks/test_lambda_function.py::test_lambda_call - pytorch_li...
tests/callbacks/test_model_summary.py::test_model_summary_callback_with_weights_summary
tests/callbacks/test_model_summary.py::test_model_summary_callback_override_weights_summary_flag
tests/callbacks/test_quantization.py::test_quantize_torchscript - pyto...
tests/callbacks/test_stochastic_weight_avg.py::test_swa_warns - pytorc...
tests/callbacks/test_stochastic_weight_avg.py::test_trainer_and_stochastic_weight_avg[False-True]
tests/callbacks/test_stochastic_weight_avg.py::test_trainer_and_stochastic_weight_avg[True-True]
tests/callbacks/test_timer.py::test_trainer_flag - AssertionError: ass...
tests/callbacks/test_timer.py::test_timer_stops_training - AssertionEr...
tests/callbacks/test_tqdm_progress_bar.py::test_tqdm_progress_bar_on[callbacks1-1]
tests/callbacks/test_tqdm_progress_bar.py::test_tqdm_progress_bar_on[callbacks2-2]
tests/callbacks/test_tqdm_progress_bar.py::test_tqdm_progress_bar_on[callbacks3-0]
tests/callbacks/test_tqdm_progress_bar.py::test_tqdm_progress_bar_on[callbacks4-0]
tests/callbacks/test_tqdm_progress_bar.py::test_tqdm_progress_bar_on[callbacks5-1]
tests/callbacks/test_tqdm_progress_bar.py::test_tqdm_progress_bar_off[callbacks0-0-True]
tests/callbacks/test_tqdm_progress_bar.py::test_tqdm_progress_bar_off[callbacks1-False-True]
tests/callbacks/test_tqdm_progress_bar.py::test_tqdm_progress_bar_off[callbacks2-0-True]
tests/callbacks/test_tqdm_progress_bar.py::test_tqdm_progress_bar_off[callbacks3-1-False]
tests/callbacks/test_tqdm_progress_bar.py::test_tqdm_progress_bar_totals
tests/callbacks/test_tqdm_progress_bar.py::test_tqdm_progress_bar_progress_refresh[0]
tests/callbacks/test_tqdm_progress_bar.py::test_tqdm_progress_bar_progress_refresh[1]
tests/callbacks/test_tqdm_progress_bar.py::test_tqdm_progress_bar_progress_refresh[50]
tests/callbacks/test_tqdm_progress_bar.py::test_tqdm_progress_bar_value_on_colab
tests/checkpointing/test_model_checkpoint.py::test_model_checkpoint_save_last_none_monitor
tests/checkpointing/test_model_checkpoint.py::test_model_checkpoint_save_last_warning[True-True-True-1]
tests/checkpointing/test_model_checkpoint.py::test_model_checkpoint_save_last_warning[True-True-True-2]
tests/checkpointing/test_model_checkpoint.py::test_model_checkpoint_save_last_warning[True-True-False-1]
tests/checkpointing/test_model_checkpoint.py::test_model_checkpoint_save_last_warning[True-True-False-2]
tests/core/test_datamodules.py::test_define_as_dataclass - pytorch_lig...
tests/core/test_datamodules.py::test_inconsistent_prepare_data_per_node
tests/deprecated_api/test_remove_1-7.py::test_v1_7_0_resume_from_checkpoint_trainer_constructor
tests/helpers/test_models.py::test_models[None-BoringModel] - pytorch_...
tests/helpers/test_models.py::test_models[None-BasicGAN] - pytorch_lig...
tests/helpers/test_models.py::test_models[None-ParityModuleRNN] - pyto...
tests/helpers/test_models.py::test_models[None-ParityModuleMNIST] - py...
tests/helpers/test_models.py::test_models[ClassifDataModule-ClassificationModel]
tests/helpers/test_models.py::test_models[RegressDataModule-RegressionModel]
tests/loggers/test_all.py::test_loggers_fit_test_all - pytorch_lightni...
tests/loggers/test_all.py::test_loggers_save_dir_and_weights_save_path_all
tests/loggers/test_all.py::test_loggers_pickle_all[TestTubeLogger] - p...
tests/loggers/test_all.py::test_logger_reset_correctly[Batch-size-Finder]
tests/loggers/test_all.py::test_logger_created_on_rank_zero_only[TestTubeLogger]
tests/loggers/test_all.py::test_logger_with_prefix_all - pytorch_light...
tests/loggers/test_tensorboard.py::test_tensorboard_log_graph[example_input_array1]
tests/loggers/test_tensorboard.py::test_tensorboard_missing_folder_warning
tests/loops/test_loops.py::test_fit_can_fail_during_validation[0.5-train_datasets0-val_datasets0]
tests/loops/test_loops.py::test_fit_can_fail_during_validation[0.5-train_datasets1-val_datasets1]
tests/loops/test_loops.py::test_fit_can_fail_during_validation[1.0-train_datasets0-val_datasets0]
tests/loops/test_loops.py::test_fit_can_fail_during_validation[1.0-train_datasets1-val_datasets1]
tests/models/test_hooks.py::test_trainer_model_hook_system_fit[True-kwargs0]
tests/models/test_hooks.py::test_trainer_model_hook_system_fit[True-kwargs1]
tests/models/test_hooks.py::test_trainer_model_hook_system_fit[True-kwargs2]
tests/models/test_hooks.py::test_trainer_model_hook_system_fit[False-kwargs0]
tests/models/test_hooks.py::test_trainer_model_hook_system_fit[False-kwargs1]
tests/models/test_hooks.py::test_trainer_model_hook_system_fit[False-kwargs2]
tests/models/test_hooks.py::test_trainer_model_hook_system_fit_no_val_and_resume
tests/models/test_hooks.py::test_trainer_model_hook_system_eval[validate-validation-val-x-0]
tests/models/test_hooks.py::test_trainer_model_hook_system_eval[validate-validation-val-x-2]
tests/models/test_hooks.py::test_trainer_model_hook_system_eval[test-test-test-y-0]
tests/models/test_hooks.py::test_trainer_model_hook_system_eval[test-test-test-y-2]
tests/models/test_hooks.py::test_trainer_model_hook_system_predict - p...
tests/models/test_hooks.py::test_trainer_datamodule_hook_system - pyto...
tests/models/test_torchscript.py::test_torchscript_input_output[BoringModel]
tests/models/test_torchscript.py::test_torchscript_input_output[ParityModuleRNN]
tests/models/test_torchscript.py::test_torchscript_input_output[BasicGAN]
tests/models/test_torchscript.py::test_torchscript_example_input_output_trace[BoringModel]
tests/models/test_torchscript.py::test_torchscript_example_input_output_trace[ParityModuleRNN]
tests/models/test_torchscript.py::test_torchscript_example_input_output_trace[BasicGAN]
tests/models/test_torchscript.py::test_torchscript_input_output_trace
tests/models/test_torchscript.py::test_torchscript_device[device0] - p...
tests/models/test_torchscript.py::test_torchscript_device[device1] - p...
tests/models/test_torchscript.py::test_torchscript_retain_training_state
tests/models/test_torchscript.py::test_torchscript_properties[BoringModel]
tests/models/test_torchscript.py::test_torchscript_properties[ParityModuleRNN]
tests/models/test_torchscript.py::test_torchscript_properties[BasicGAN]
tests/models/test_torchscript.py::test_torchscript_save_load[BoringModel]
tests/models/test_torchscript.py::test_torchscript_save_load[ParityModuleRNN]
tests/models/test_torchscript.py::test_torchscript_save_load[BasicGAN]
tests/models/test_torchscript.py::test_torchscript_save_load_custom_filesystem[BoringModel]
tests/models/test_torchscript.py::test_torchscript_save_load_custom_filesystem[ParityModuleRNN]
tests/models/test_torchscript.py::test_torchscript_save_load_custom_filesystem[BasicGAN]
tests/plugins/test_amp_plugins.py::test_precision_selection_raises - p...
tests/plugins/test_ddp_spawn_plugin.py::test_ddp_spawn_extra_parameters
tests/plugins/test_ddp_spawn_plugin.py::test_ddp_spawn_add_get_queue
tests/plugins/environments/test_kubeflow_environment.py::test_attributes_from_environment_variables
tests/plugins/environments/test_slurm_environment.py::test_attributes_from_environment_variables
tests/plugins/environments/test_torchelastic_environment.py::test_attributes_from_environment_variables
tests/profiler/test_profiler.py::test_simple_profiler_logs - assert 0 ...
tests/profiler/test_profiler.py::test_advanced_profiler_cprofile_deepcopy
tests/trainer/test_dataloaders.py::test_request_dataloader - pytorch_l...
tests/trainer/test_trainer.py::test_trainer_min_steps_and_min_epochs_not_reached
tests/trainer/test_trainer.py::test_nan_loss_detection - pytorch_light...
tests/trainer/test_trainer.py::test_invalid_terminate_on_nan - pytorch...
tests/trainer/test_trainer.py::test_nan_params_detection - pytorch_lig...
tests/trainer/test_trainer.py::test_on_exception_hook - pytorch_lightn...
tests/trainer/test_trainer.py::test_trainer_config[trainer_kwargs1-expected1]
tests/trainer/test_trainer.py::test_trainer_config[trainer_kwargs2-expected2]
tests/trainer/test_trainer.py::test_trainer_config[trainer_kwargs3-expected3]
tests/trainer/test_trainer.py::test_trainer_config[trainer_kwargs4-expected4]
tests/trainer/test_trainer.py::test_trainer_config[trainer_kwargs6-expected6]
tests/trainer/test_trainer.py::test_trainer_config[trainer_kwargs8-expected8]
tests/trainer/test_trainer.py::test_trainer_config[trainer_kwargs9-expected9]
tests/trainer/test_trainer.py::test_trainer_config[trainer_kwargs11-expected11]
tests/trainer/test_trainer.py::test_trainer_config[trainer_kwargs13-expected13]
tests/trainer/test_trainer.py::test_trainer_config[trainer_kwargs14-expected14]
tests/trainer/test_trainer.py::test_trainer_config[trainer_kwargs15-expected15]
tests/trainer/test_trainer.py::test_trainer_config[trainer_kwargs16-expected16]
tests/trainer/test_trainer.py::test_trainer_config[trainer_kwargs17-expected17]
tests/trainer/test_trainer.py::test_log_every_n_steps[10-10-1] - pytor...
tests/trainer/test_trainer.py::test_log_every_n_steps[3-10-1] - pytorc...
tests/trainer/test_trainer.py::test_log_every_n_steps[3-10-5] - pytorc...
tests/trainer/connectors/test_callback_connector.py::test_checkpoint_callbacks_are_last
tests/trainer/connectors/test_callback_connector.py::test_attach_model_callbacks
tests/trainer/connectors/test_callback_connector.py::test_attach_model_callbacks_override_info
tests/trainer/flags/test_fast_dev_run.py::test_callbacks_and_logger_not_called_with_fastdevrun[1]
tests/trainer/flags/test_fast_dev_run.py::test_callbacks_and_logger_not_called_with_fastdevrun[4]
tests/trainer/flags/test_min_max_epochs.py::test_min_max_steps_epochs[None-3-None-None]
tests/trainer/flags/test_min_max_epochs.py::test_min_max_steps_epochs[1-3-None-None]
tests/trainer/flags/test_min_max_epochs.py::test_min_max_steps_epochs[None-3-10-None]
tests/trainer/logging_/test_logger_connector.py::test_fx_validator_integration
tests/tuner/test_lr_finder.py::test_lr_find_with_bs_scale - pytorch_li...
tests/tuner/test_scale_batch_size.py::test_scale_batch_size_method_with_model_or_datamodule[2--1]
tests/tuner/test_scale_batch_size.py::test_scale_batch_size_method_with_model_or_datamodule[2-2]
tests/tuner/test_scale_batch_size.py::test_scale_batch_size_method_with_model_or_datamodule[2-None]
tests/tuner/test_scale_batch_size.py::test_scale_batch_size_method_with_model_or_datamodule[None-2]
tests/tuner/test_scale_batch_size.py::test_scale_batch_size_method_with_model_or_datamodule[16-16]
tests/tuner/test_scale_batch_size.py::test_model_reset_correctly - pyt...
tests/tuner/test_scale_batch_size.py::test_trainer_reset_correctly - p...
tests/tuner/test_scale_batch_size.py::test_auto_scale_batch_size_trainer_arg[power]
tests/tuner/test_scale_batch_size.py::test_auto_scale_batch_size_trainer_arg[binsearch]
tests/tuner/test_scale_batch_size.py::test_auto_scale_batch_size_trainer_arg[True]
tests/tuner/test_scale_batch_size.py::test_auto_scale_batch_size_set_model_attribute[True]
tests/tuner/test_scale_batch_size.py::test_auto_scale_batch_size_set_model_attribute[False]
tests/tuner/test_scale_batch_size.py::test_call_to_trainer_method[power]
tests/tuner/test_scale_batch_size.py::test_call_to_trainer_method[binsearch]
tests/tuner/test_scale_batch_size.py::test_auto_scale_batch_size_with_amp
tests/tuner/test_scale_batch_size.py::test_scale_batch_size_no_trials
tests/tuner/test_scale_batch_size.py::test_scale_batch_size_fails_with_unavailable_mode
tests/tuner/test_scale_batch_size.py::test_dataloader_reset_with_scale_batch_size[power]
tests/tuner/test_scale_batch_size.py::test_dataloader_reset_with_scale_batch_size[binsearch]
tests/utilities/test_model_summary.py::test_invalid_weights_summmary
tests/utilities/test_model_summary.py::test_empty_model_summary_shapes[full]
tests/utilities/test_model_summary.py::test_empty_model_summary_shapes[top]
tests/utilities/test_model_summary.py::test_linear_model_summary_shapes[device0-full]
tests/utilities/test_model_summary.py::test_linear_model_summary_shapes[device0-top]
tests/utilities/test_model_summary.py::test_linear_model_summary_shapes[device1-full]
tests/utilities/test_model_summary.py::test_linear_model_summary_shapes[device1-top]
tests/utilities/test_model_summary.py::test_rnn_summary_shapes[full]
tests/utilities/test_model_summary.py::test_rnn_summary_shapes[top] - ...
tests/utilities/test_model_summary.py::test_summary_parameter_count[full]
tests/utilities/test_model_summary.py::test_summary_parameter_count[top]
tests/utilities/test_model_summary.py::test_summary_layer_types[full]
tests/utilities/test_model_summary.py::test_summary_layer_types[top]
tests/utilities/test_model_summary.py::test_summary_with_scripted_modules[full]
tests/utilities/test_model_summary.py::test_summary_with_scripted_modules[top]
tests/utilities/test_model_summary.py::test_example_input_array_types[example_input0-?-full]
tests/utilities/test_model_summary.py::test_example_input_array_types[example_input0-?-top]
tests/utilities/test_model_summary.py::test_example_input_array_types[example_input1-expected_size1-full]
tests/utilities/test_model_summary.py::test_example_input_array_types[example_input1-expected_size1-top]
tests/utilities/test_model_summary.py::test_example_input_array_types[example_input2-?-full]
tests/utilities/test_model_summary.py::test_example_input_array_types[example_input2-?-top]
tests/utilities/test_model_summary.py::test_example_input_array_types[example_input3-?-full]
tests/utilities/test_model_summary.py::test_example_input_array_types[example_input3-?-top]
tests/utilities/test_model_summary.py::test_example_input_array_types[example_input4-expected_size4-full]
tests/utilities/test_model_summary.py::test_example_input_array_types[example_input4-expected_size4-top]
tests/utilities/test_model_summary.py::test_example_input_array_types[example_input5-expected_size5-full]
tests/utilities/test_model_summary.py::test_example_input_array_types[example_input5-expected_size5-top]
tests/utilities/test_model_summary.py::test_example_input_array_types[example_input6-expected_size6-full]
tests/utilities/test_model_summary.py::test_example_input_array_types[example_input6-expected_size6-top]
tests/utilities/test_model_summary.py::test_model_size[full] - pytorch...
tests/utilities/test_model_summary.py::test_model_size[top] - pytorch_...
tests/utilities/test_model_summary.py::test_empty_model_size[full] - p...
tests/utilities/test_model_summary.py::test_empty_model_size[top] - py...
tests/utilities/test_model_summary.py::test_max_depth_equals_mode_interface

carmocca added the ci Continuous Integration label Oct 15, 2021

carmocca added this to the v1.5 milestone Oct 15, 2021

carmocca mentioned this issue Oct 15, 2021

Fail the test when a DeprecationWarning is raised #9940

Merged

9 tasks

This was referenced Oct 15, 2021

LightningDeprecationWarning: DataModule.setup has already been called #9943

Closed

Remove deprecated DataModule.dims usage in tests #9948

Merged

Use non-deprecated options in tests #9949

Merged

Avoid deprecation warning after #9901 #9951

Merged

carmocca added the good first issue Good for newcomers label Oct 15, 2021

daniellepintz mentioned this issue Oct 16, 2021

Don't raise DeprecationWarning for LoggerConnector.gpus_metrics #9959

Merged

12 tasks

daniellepintz mentioned this issue Oct 25, 2021

Update accelerator to strategy in tests #10144

Closed

12 tasks

awaelchli modified the milestones: v1.5, v1.6 Nov 4, 2021

carmocca removed the good first issue Good for newcomers label Nov 17, 2021

carmocca closed this as completed in #9940 Nov 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fail the test when a `DeprecationWarning` is raised #9939

Fail the test when a `DeprecationWarning` is raised #9939

carmocca commented Oct 15, 2021 •

edited

Loading

daniellepintz commented Oct 15, 2021

carmocca commented Oct 15, 2021

daniellepintz commented Oct 17, 2021

carmocca commented Oct 18, 2021 •

edited

Loading

Fail the test when a DeprecationWarning is raised #9939

Fail the test when a DeprecationWarning is raised #9939

Comments

carmocca commented Oct 15, 2021 • edited Loading

Proposed refactoring or deprecation

Motivation

Pitch

If you enjoy Lightning, check out our other projects! ⚡

daniellepintz commented Oct 15, 2021

carmocca commented Oct 15, 2021

daniellepintz commented Oct 17, 2021

carmocca commented Oct 18, 2021 • edited Loading

Fail the test when a `DeprecationWarning` is raised #9939

Fail the test when a `DeprecationWarning` is raised #9939

carmocca commented Oct 15, 2021 •

edited

Loading

carmocca commented Oct 18, 2021 •

edited

Loading