You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The two ways of loading a LightningModule from checkpoint only differ in one argument, the tags_csv.
Motivation
The code is almost identical for both and the purpose is the same. If we merge these two into one function, it would simplify the API.
Pitch
Combine load_from_metrics(cls, weights_path, tags_csv, map_location=None) and load_from_checkpoint(cls, checkpoint_path, map_location=None) into a single signature:
🚀 Feature
The two ways of loading a LightningModule from checkpoint only differ in one argument, the tags_csv.
Motivation
The code is almost identical for both and the purpose is the same. If we merge these two into one function, it would simplify the API.
Pitch
Combine
load_from_metrics(cls, weights_path, tags_csv, map_location=None)
andload_from_checkpoint(cls, checkpoint_path, map_location=None)
into a single signature:and make load_from_metrics deprecated.
Alternatives
keep as is, not a big deal :)
The text was updated successfully, but these errors were encountered: