-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Review guidelines
Jirka Borovec edited this page Mar 14, 2020
·
12 revisions
Some recommended steps for reviewing open PRs.
- Check the source issues if the fix solves it
- Read the changes if they are aligned with our code-base
- Check if the changes (fixed issue) are covered by tests
- Check if the change is mentioned in CHANGELOG (no need for typos, docs and CI)
- be nice and constructive, remember you fist PR and what helped you / made motivated to continue with contributing
- use suggestions for simple edits when you know what it shall be intead of long description (you can still add short justification of your proposal) so the author can simply accept it...