Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slower performance for Torchmetrics PESQ #1222

Closed
ashinkajay opened this issue Sep 14, 2022 · 2 comments
Closed

Slower performance for Torchmetrics PESQ #1222

ashinkajay opened this issue Sep 14, 2022 · 2 comments
Labels
bug / fix Something isn't working help wanted Extra attention is needed topic: Audio

Comments

@ashinkajay
Copy link

🐛 Bug

Multiprocessing capability is missing for Torchmetrics PESQ while the underlying library ludlows/python-pesq have that option.
As a result, the torchmetrics version of PESQ performs slower than ludlows/python-pesq.

To Reproduce

Run PESQ for a batch of 100 audios with a minimum duration of 10 seconds for each audio.

Code sample

Python notebook code attachment here: analysis.zip

Expected behavior

Both the Torchmetrics PESQ and ludlows/python-pesq should take almost the same time to compute the PESQ score.

Environment

  • Python - 3.10.4 (installed using conda)

Below libraries installed using pip

  • TorchMetrics - 0.9.3
  • PyTorch - 1.12.1
  • Torchaudio - 0.12.1
  • OS: Ubuntu 20.04.4 LTS

Additional context

References
ludlows/python-pesq: https://github.com/ludlows/PESQ

@ashinkajay ashinkajay added bug / fix Something isn't working help wanted Extra attention is needed labels Sep 14, 2022
@ashinkajay
Copy link
Author

Need to add more details

@ashinkajay ashinkajay closed this as not planned Won't fix, can't repro, duplicate, stale Sep 14, 2022
@Borda
Copy link
Member

Borda commented Sep 14, 2022

duplicated with #1223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working help wanted Extra attention is needed topic: Audio
Projects
None yet
Development

No branches or pull requests

2 participants