Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mean Absolute Percentage Error metric #235

Closed
pranjaldatta opened this issue May 8, 2021 · 4 comments · Fixed by #248
Closed

Add Mean Absolute Percentage Error metric #235

pranjaldatta opened this issue May 8, 2021 · 4 comments · Fixed by #248
Labels
enhancement New feature or request help wanted Extra attention is needed New metric

Comments

@pranjaldatta
Copy link
Contributor

🚀 Feature

Add Mean Absolute Percentage Error to the list of regression metrics.

Motivation

It's a neat metric that is included in the scikit-learn package - considered to be a bit more intuitive than MAE and more sensitive to relative errors. More can be found on its Wikipedia article.

Pitch

Mean Absolute Percentage Error to be included among the regression metrics.

Alternatives

Additional context

I would be really grateful if someone could judge whether such a metric is necessary in the first place (considering it has some documented issues as noted in the wiki here). Although I guess, scikit-learn deals with the 0-related issues by adding an arbitrary constant to the denominator.

If the community finds that such a metric would be a helpful addition to this awesome package, I would love to contribute this!

@pranjaldatta pranjaldatta added enhancement New feature or request help wanted Extra attention is needed labels May 8, 2021
@github-actions
Copy link

github-actions bot commented May 8, 2021

Hi! thanks for your contribution!, great first issue!

@SkafteNicki
Copy link
Member

@pranjaldatta looks like a great addtion. Would you be up for sending a PR?
I see no problem in the limitations of this metrics, we just need to document some of them. Finally, we just provide the metrics, but it is up to the user to use them correctly

@pranjaldatta
Copy link
Contributor Author

@SkafteNicki Thanks! I'll send a PR right away in 2/3 days. I'll make sure to reflect some of the limitations in the associated documentation.

@Borda Borda changed the title [New Metric] Add Mean Absolute Percentage Error metric Add Mean Absolute Percentage Error metric Jan 26, 2022
@kowshikthopalli
Copy link

Is there a reason why MAPE in torchmetrics doesn't multiply with 100 to actually get the percent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed New metric
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants