Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _filter_kwargs in ClasswiseWrapper metric wrapper #2542

Closed
ioangatop opened this issue May 15, 2024 · 3 comments · Fixed by #2575
Closed

Add _filter_kwargs in ClasswiseWrapper metric wrapper #2542

ioangatop opened this issue May 15, 2024 · 3 comments · Fixed by #2575
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ioangatop
Copy link

ioangatop commented May 15, 2024

As the ClasswiseWrapper accepts agnostic *args, **kwargs arguments, its not handy to use it in a MetricColletion, as tailored input arguments for other metrics get passed in the metrics.

It would be great, just like in MetricColletion, to add the _filter_kwargs for the metric

@ioangatop ioangatop added the enhancement New feature or request label May 15, 2024
Copy link

Hi! thanks for your contribution!, great first issue!

@Borda
Copy link
Member

Borda commented May 15, 2024

It would be great, just like in MetricColletion, to add the _filter_kwargs for the metric

sounds fine to me... what do you think @justusschock @SkafteNicki ?

@SkafteNicki SkafteNicki added this to the v1.3.x milestone May 31, 2024
@SkafteNicki SkafteNicki added the documentation Improvements or additions to documentation label May 31, 2024
@SkafteNicki SkafteNicki self-assigned this May 31, 2024
@SkafteNicki SkafteNicki removed the documentation Improvements or additions to documentation label May 31, 2024
@ioangatop
Copy link
Author

Thanks a lot @SkafteNicki @stancld and @Borda 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants