-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPU support in BootStrapper #455
Labels
Comments
frcnt
added
bug / fix
Something isn't working
help wanted
Extra attention is needed
labels
Aug 17, 2021
Hi! thanks for your contribution!, great first issue! |
@frcnt good catch, are you interested in sending a fix? @SkafteNicki ay assist 🐰 |
I took a look at it yesterday, can send a fix soon :] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 Bug
BootStrapper yields a device error when the predicted and target tensors, along with the metric are on GPU.
Regardless of the device on which the tensors and the metric are hosted, this call to
_bootstrap_sampler
returns indices hosted on the CPU.The device error is later thrown when calling
torch.index_select
.To Reproduce
Steps to reproduce the behavior:
Stack traces produced
Code sample
Expected behavior
The same behaviour as when executing the above piece of code on CPU.
Environment
conda
,pip
, source): condaSuggestion
After calling
_bootstrap_sampler
, the indices should be moved on the same device as the metric.The text was updated successfully, but these errors were encountered: