Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove type: ignore across text metrics #741

Closed
stancld opened this issue Jan 10, 2022 · 1 comment
Closed

Remove type: ignore across text metrics #741

stancld opened this issue Jan 10, 2022 · 1 comment
Assignees
@stancld
Labels
good first issue Good for newcomers refactoring refactoring and code health
Milestone
v0.7

Comments

@stancld
Copy link
Contributor

stancld commented Jan 10, 2022

Code health

Remove type: ignore statements used on various places across text metrics that are used for mypy compatibility when handling the backward compatibility during the transition to the unified preds, target input naming.

Following issue #716 and PRs #723, #727
@stancld stancld added good first issue Good for newcomers refactoring refactoring and code health labels Jan 10, 2022
@stancld stancld added this to the v0.8 milestone Jan 10, 2022
@stancld stancld self-assigned this Jan 10, 2022
@Borda
Copy link
Member

Borda commented Jan 12, 2022

I think that this won't be needed in the end... 🐰

@Borda Borda closed this as completed Jan 12, 2022
@Borda Borda modified the milestones: v0.8, v0.7 Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stancld stancld

Labels
good first issue Good for newcomers refactoring refactoring and code health
Projects
None yet
Milestone
v0.7
Development

No branches or pull requests
2 participants
@Borda @stancld