Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU type for mean average precision #821

Closed
gianscarpe opened this issue Feb 1, 2022 · 7 comments · Fixed by #822
Closed

IOU type for mean average precision #821

gianscarpe opened this issue Feb 1, 2022 · 7 comments · Fixed by #822
Labels
enhancement New feature or request

Comments

@gianscarpe
Copy link
Contributor

🚀 Feature

would be nice to have detection.map.MeanAveragePrecision similar to what pycocotools provides. In particular, introduced a parameter "iou_type" in order to choose between "bbox" and "segm" (for instance segmentation).

Motivation

Having a metric for instance segmentation, which is currently unavailable.

Pitch

Instantiate MeanAveragePrecision(..,, iou_type="segm") to evaluate instance segmentation

Alternatives

Additional context

@gianscarpe gianscarpe added the enhancement New feature or request label Feb 1, 2022
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Hi! thanks for your contribution!, great first issue!

@drozzy
Copy link

drozzy commented Feb 8, 2022

Could you explain the difference between bbox iou and the segmentation IoU?
I saw a reference to this in the torchmetrics docs and wasn't sure what that meant.

@Borda
Copy link
Member

Borda commented Feb 11, 2022

@gianscarpe ^^

@gianscarpe
Copy link
Contributor Author

Could you explain the difference between bbox iou and the segmentation IoU? I saw a reference to this in the torchmetrics docs and wasn't sure what that meant.

Hi and thanks for the question! As in pycocotools (the official COCO library for mAP), the difference between the two regards how to compute positive and negative pairs of bounding-box. BBox_IOU computes how much the bounding-boxes overlap, while segmentation-iou evaluates how much the segmentation masks (ground-truth and predicted). Different way to compute intersections and unions :)

@drozzy
Copy link

drozzy commented Feb 14, 2022

Is it perhaps similar to the Non-Max Suppression? Pages 41-45:
https://web.eecs.umich.edu/~justincj/slides/eecs498/FA2020/598_FA2020_lecture15.pdf

Screenshot from 2022-02-14 16-23-44

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 16, 2022
@gianscarpe
Copy link
Contributor Author

PR: #822

@stale stale bot removed the wontfix label Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants