Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code for next v0.9 #956

Closed
9 tasks done
Borda opened this issue Apr 15, 2022 · 9 comments
Closed
9 tasks done

Remove deprecated code for next v0.9 #956

Borda opened this issue Apr 15, 2022 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers refactoring refactoring and code health
Milestone

Comments

@Borda
Copy link
Member

Borda commented Apr 15, 2022

🚀 Feature

Let's start standard deprecated API cleaning and also split it into smaller contributions that are not affecting each other, and they are easier/faster to review... So each of the following ToDO shall be addressed in a single PR.
Before you start working on any, pls ping/comment us here so we can assign it to you to reduce work collision 🐰

Motivation

Regular API cleaning of deprecated API keeping the codebase in a healthy state

Pitch

Ideal hands-on / first contribution because of its low complexity 💜

Alternatives

Additional context

@Borda Borda added enhancement New feature or request good first issue Good for newcomers labels Apr 15, 2022
@Borda Borda added this to the v0.9 milestone Apr 15, 2022
@Borda Borda pinned this issue Apr 15, 2022
@Borda Borda mentioned this issue Apr 15, 2022
4 tasks
@tanmoyio
Copy link
Contributor

compute_on_step in classification 🖐

@tanmoyio
Copy link
Contributor

compute_on_step in audio 🖐

@vumichien
Copy link
Contributor

I will work on compute_on_step in regression

@Borda Borda added the refactoring refactoring and code health label Apr 19, 2022
@phaseolud
Copy link
Contributor

Hey, I would like to work on compute_on_step in image, is that possible?

@stancld
Copy link
Contributor

stancld commented Apr 22, 2022

Hey, I would like to work on compute_on_step in image, is that possible?

Yes, definitely! Feel free to start! :]

@phaseolud
Copy link
Contributor

I would like to pick up retrieval as well! 😄

@SkafteNicki
Copy link
Member

@tanmoyio how is it going with the change for audio?

@tanmoyio
Copy link
Contributor

tanmoyio commented May 4, 2022

@tanmoyio sorry I was in vacation, I will do it today.

@Borda
Copy link
Member Author

Borda commented May 5, 2022

Cool! 🎉 Thank you all!

@Borda Borda closed this as completed May 5, 2022
@SkafteNicki SkafteNicki unpinned this issue May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers refactoring refactoring and code health
Projects
None yet
Development

No branches or pull requests

6 participants