-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update self.log #132
Labels
Comments
loodvn
added
bug / fix
Something isn't working
help wanted
Extra attention is needed
labels
Jan 7, 2022
Hi @loodvn are you interested in sending out fix? :] |
Unfortunately not, sorry - Lightning-Universe/lightning-bolts#793 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 Bug
Some tutorials still return non-detached tensors in
training_step
- this is deprecated in 1.6 and may cause memory leaks if people follow those patterns.e.g.
output = OrderedDict({"loss": g_loss, "progress_bar": tqdm_dict, "log": tqdm_dict})
The error pops up in the autogenerated docs here: https://pytorch-lightning.readthedocs.io/en/stable/notebooks/lightning_examples/basic-gan.html
I raised this in Lightning-Universe/lightning-bolts#793 too.
I see the examples in https://github.com/PyTorchLightning/pytorch-lightning/tree/master/pl_examples already defer to lightning bolts for more robust examples - wherever a good source of docs/best practices should be, I think this specific error be fixed? (these examples are also discussed in #71).
Thanks, loving the library btw! :)
The text was updated successfully, but these errors were encountered: