Breaking change in actions/upload-artifact@v3 makes check-package.yml always fail

[shino16]

🐛 Bug

From September 2nd, 2024, we will no longer include hidden files and folders as part of the default upload of the v3 and v4 upload-artifact actions.
https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/

This change in actions/upload-artifact@v3 causes check-package.yml to fail.

Example and Explanation

Failed CI

init-store did the following:

utilities/.github/workflows/check-package.yml

Lines 65 to 70 in 2549f80

	- run: mkdir dist && touch dist/.placeholder
	- name: Upload 📤
	uses: actions/upload-artifact@v3
	with:
	name: ${{ inputs.artifact-name }}
	path: dist

.placeholder was ignored, so this resulted in the following message:

Warning: No files were found with the provided path: dist. No artifacts will be uploaded.

The subsequent job pkg-build tried to download artifacts under the same name in pkg-create:

utilities/.github/workflows/check-package.yml

Lines 98 to 101 in 2549f80

	- name: Create package 📦
	uses: ./.cicd/.github/actions/pkg-create
	with:
	artifact-name: ${{ inputs.artifact-name }}

utilities/.github/actions/pkg-create/action.yml

Lines 25 to 30 in 2549f80

	- name: Download 📥 previous packages
	if: ${{ inputs.artifact-name != '' }}
	uses: actions/download-artifact@v3
	with:
	name: ${{ inputs.artifact-name }}
	path: pypi

and produced the following error message:

Error: Unable to find any artifacts for the associated workflow

Possible Solution

Set include-hidden-files to true.
https://github.com/actions/upload-artifact/blob/b18b1d32f3f31abcdc29dee3f2484801fe7822f4/action.yml#L43-L47

[Borda]

@shino16 thank ou for this report and quick fix!
the patch was merged and all just released as 0.11.7

[shino16]

Thank you for your quick response!