Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Intersection over Union loss #370

Closed
briankosw opened this issue Nov 16, 2020 · 3 comments · Fixed by #469
Closed

Add Intersection over Union loss #370

briankosw opened this issue Nov 16, 2020 · 3 comments · Fixed by #469
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
v0.3

Comments

@briankosw
Copy link
Contributor

🚀 Feature

Since #251 includes GIoU loss, I think having IoU loss only makes sense.

Motivation

Pitch

I can implement this pretty quickly since I've been working on GIoU #347.

Alternatives

Additional context
@briankosw briankosw added enhancement New feature or request help wanted Extra attention is needed labels Nov 16, 2020
@github-actions
Copy link

Hi! thanks for your contribution!, great first issue!

@briankosw briankosw changed the title Intersection of Union loss Intersection over Union loss Nov 17, 2020
@akihironitta
Copy link
Contributor

akihironitta commented Nov 17, 2020 •
edited
Loading

@briankosw Thank you for your suggestion! I think it'd be nice to have IoU loss as well.

As far as I understand, GIoU loss and IoU loss can share the most of the code (both use IoU), so it may be reasonable to extract IoU from GIoU loss in #347 and use it in IoU loss here.

@briankosw
Copy link
Contributor Author

@akihironitta absolutely there is significantly overlap. I'll work on a PR for IoU loss!

@briankosw briankosw mentioned this issue Nov 19, 2020
Merged
8 tasks
@akihironitta akihironitta changed the title Intersection over Union loss Add Intersection over Union loss Dec 12, 2020
@briankosw briankosw mentioned this issue Dec 21, 2020
Merged
8 tasks
@Borda Borda closed this as completed in #469 Jan 3, 2021
@Borda Borda added this to the v0.3 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
v0.3
Development

Successfully merging a pull request may close this issue.

Intersection over Union Metric/Loss
3 participants
@Borda @briankosw @akihironitta