Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DCGAN #401

Closed
chris-clem opened this issue Nov 24, 2020 · 5 comments · Fixed by #403
Closed

Add DCGAN #401

chris-clem opened this issue Nov 24, 2020 · 5 comments · Fixed by #403
Labels
enhancement New feature or request help wanted Extra attention is needed model
Milestone

Comments

@chris-clem
Copy link
Contributor

🚀 Feature

How about adding a DCGAN implementation to Bolts? In a private repo, I refactored the PyTorch example implementation (https://github.com/pytorch/examples/blob/master/dcgan/main.py) to PyTorch Lightning and I am happy to create a PR with it if you want.

Motivation

DCGAN can be used as a solid GAN baseline and therefore should be included in Bolts.

@chris-clem chris-clem added enhancement New feature or request help wanted Extra attention is needed labels Nov 24, 2020
@oke-aditya
Copy link
Contributor

I think the above example on pytorch is really very good implementation. It was made by authors of DCGAN papers,

@chris-clem chris-clem mentioned this issue Nov 24, 2020
8 tasks
@chris-clem
Copy link
Contributor Author

I added the implementation to the PR. Will add tests tomorrow.

@chris-clem
Copy link
Contributor Author

@akihironitta I added the tests. From my side, the PR would be ready for review :)

@oke-aditya
Copy link
Contributor

oke-aditya commented Nov 25, 2020

Just a thought, the orignal paper uses LSUN bedroom dataset which might be nice to use and is available in torchvision !

@akihironitta akihironitta changed the title Add DCGAN Implementation Add DCGAN Dec 12, 2020
@chris-clem
Copy link
Contributor Author

Just a thought, the orignal paper uses LSUN bedroom dataset which might be nice to use and is available in torchvision !

Good point! I will add it to the PR.

@Borda Borda added this to the v0.3 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed model
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants