Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is an unreasonable use of MoCov2 #615

Closed
ydar95 opened this issue Apr 8, 2021 · 5 comments
Closed

There is an unreasonable use of MoCov2 #615

ydar95 opened this issue Apr 8, 2021 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed won't fix This will not be worked on

Comments

@ydar95
Copy link

ydar95 commented Apr 8, 2021

In ,MoCo2_Module
When PL Run this module, "validation_step" will call "forward" to calc "output, target" , but, at "forward", it must to call "_dequeue_and_enqueue" and "_momentum_update_key_encoder"。
I think this will leak the test-set infos, and momentum-update in validation_step.
@ydar95 ydar95 added fix fixing issues... help wanted Extra attention is needed labels Apr 8, 2021
@github-actions
Copy link

github-actions bot commented Apr 8, 2021

Hi! thanks for your contribution!, great first issue!

@ydar95
Copy link
Author

ydar95 commented Apr 8, 2021

image

This was referenced May 5, 2021
Closed
Merged
@stale
Copy link

stale bot commented Jun 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Jun 8, 2021
@stale stale bot closed this as completed Jun 18, 2021
@akihironitta
Copy link
Contributor

@ydar95 Thank you for reporting this issue. It should be addressed in #631.

@akihironitta akihironitta reopened this Jun 27, 2021
@stale stale bot removed the won't fix This will not be worked on label Jun 27, 2021
@stale
Copy link

stale bot commented Aug 27, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Aug 27, 2021
@stale stale bot closed this as completed Sep 6, 2021
@Borda Borda added bug Something isn't working and removed fix fixing issues... labels Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed won't fix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Borda @ydar95 @akihironitta