Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic Regression model regularisation error #668

Closed
stanton119 opened this issue Jun 23, 2021 · 1 comment · Fixed by #669
Closed

Classic Regression model regularisation error #668

stanton119 opened this issue Jun 23, 2021 · 1 comment · Fixed by #669
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@stanton119
Copy link
Contributor

Hi,

The L1 and L2 regularisation for both the linear and logistic regression models includes the bias, rather than just the weights.
e.g. as seen here:
https://github.com/PyTorchLightning/lightning-bolts/blob/master/pl_bolts/models/regression/linear_regression.py#L61

The regularisation is commonly only applies to the weights and the bias remains unaffected. More discussion:
https://stats.stackexchange.com/questions/86991/reason-for-not-shrinking-the-bias-intercept-term-in-regression?rq=1

@stanton119 stanton119 added fix fixing issues... help wanted Extra attention is needed labels Jun 23, 2021
@github-actions
Copy link

Hi! thanks for your contribution!, great first issue!

@Borda Borda added bug Something isn't working and removed fix fixing issues... labels Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants