Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the YOLO model with features from new variants #816

Closed
senarvi opened this issue Mar 28, 2022 · 5 comments · Fixed by #817
Closed

Upgrade the YOLO model with features from new variants #816

senarvi opened this issue Mar 28, 2022 · 5 comments · Fixed by #817
Labels
enhancement New feature or request help wanted Extra attention is needed won't fix This will not be worked on

Comments

@senarvi
Copy link
Contributor

senarvi commented Mar 28, 2022

🚀 Feature

Several new variants of the YOLO model have been proposed in the past couple of years. The current implementation in PyTorch Lightning Bolts is based on the original Darknet implementation. I have updated it with features from the new PyTorch based variants and created a pull request.

Motivation

The code has been refactored, allowing easy variation of the network architecture, target matching algorithm, or loss function. Some important changes that have been proposed to these algorithms are implemented in this pull request in a modular way. This is the only implementation that combines features from the latest variants, including YOLOv5 and YOLOX, as well as allows loading Darknet based models.

You can find my pull request here: #817

@senarvi senarvi added enhancement New feature or request help wanted Extra attention is needed labels Mar 28, 2022
@senarvi
Copy link
Contributor Author

senarvi commented Mar 28, 2022

This PR also includes the fix to the number of input channels by @kfirgedal . Maybe you could look at this pull request and say what you think?

@stale
Copy link

stale bot commented Jun 5, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Jun 5, 2022
@senarvi
Copy link
Contributor Author

senarvi commented Jun 8, 2022

I added the deeper P6 variant of YOLOv4. The depth of the network and the width of each stage can also be configured freely.

I think there are pretty significant improvements in the pull request. Is anyone interested in having a look? @kfirgedal @Borda @ethanwharris @awaelchli

@stale stale bot removed the won't fix This will not be worked on label Jun 8, 2022
@stale
Copy link

stale bot commented Aug 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Aug 12, 2022
@stale stale bot closed this as completed Sep 21, 2022
@senarvi
Copy link
Contributor Author

senarvi commented Sep 21, 2022

I did still some minor refactoring, but otherwise this pull request is pretty stable already. I think there was interest in merging this. @luca-medeiros do you have time to look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed won't fix This will not be worked on
Projects
None yet
1 participant