Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AE.from_pretrained fails on windows #876

Closed
mlamarre opened this issue Sep 6, 2022 · 1 comment
Closed

AE.from_pretrained fails on windows #876

mlamarre opened this issue Sep 6, 2022 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@mlamarre
Copy link

mlamarre commented Sep 6, 2022

🐛 Bug

AE.from_pretrained fails on windows because using os.path.join on a web url.

In \pl_bolts\models\autoencoders\basic_ae\basic_ae_module.py

pretrained_urls = {
        'cifar10-resnet18': os.path.join(_HTTPS_AWS_HUB, 'ae/ae-cifar10/checkpoints/epoch%3D96.ckpt'),
    }

To Reproduce

On Windows:

from pl_bolts.models.autoencoders import AE
ae = ae.from_pretrained('cifar10-resnet18')

Environment

  • PyTorch Version (e.g., 1.0): 3.7
  • OS (e.g., Linux): Windows
@mlamarre mlamarre added the help wanted Extra attention is needed label Sep 6, 2022
@otaj
Copy link
Contributor

otaj commented Sep 16, 2022

Hi @mlamarre, this has already been fixed over a year ago in #652. However, due to bringing it to our attention, I found one another occurrence that needed fixing.

@otaj otaj mentioned this issue Sep 16, 2022
8 tasks
@otaj otaj closed this as completed Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants