Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to install Bolts from a local directory with packaging==23.0 #970

Closed
senarvi opened this issue Jan 31, 2023 · 1 comment
Closed
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@senarvi
Copy link
Contributor

senarvi commented Jan 31, 2023

🐛 Bug

I'm unable to install Lightning Bolts using python3 -m pip install . I get the following error:

error in lightning-bolts setup command: 'extras_require' must be a dictionary whose values are strings or lists of strings containing valid project/version requirement specifiers.

I'm pretty sure it happened only after the Python package packaging was upgraded to 23.0.

To Reproduce

Steps to reproduce the behavior:

  1. Upgrade packaging: python3 -m pip install --upgrade packaging==23.0
  2. Download Bolts: git clone git@github.com:Lightning-AI/lightning-bolts.git
  3. Try to install Bolts: cd lightning-bolts && python3 -m pip install --editable .

It seems to be related to setuptools not accepting version requirements with an asterisk. I can also test it in a Python interpreter. After installing packaging==23.0, setuptools crashes if a version number such as 0.10.* is given:

>>> from setuptools import setup
>>> setup(install_requires='torchvision>=0.10.*')
error in setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; Expected end or semicolon (after version specifier)
    torchvision>=0.10.*
               ~~~~~~^

Environment

  • PyTorch Version (e.g., 1.0): 1.13
  • OS (e.g., Linux): Linux
  • How you installed PyTorch (conda, pip, source): pip
  • Python version: Tried with 3.9 and 3.10
@senarvi senarvi added the help wanted Extra attention is needed label Jan 31, 2023
@senarvi
Copy link
Contributor Author

senarvi commented Feb 1, 2023

It seems that this bug also prevents the tests from passing. Seems to work if I remove the .* from the version requirements.

@Delaunay Delaunay mentioned this issue Feb 20, 2023
8 tasks
@Borda Borda added fix fixing issues... bug Something isn't working and removed fix fixing issues... labels Jun 20, 2023
@Borda Borda closed this as completed Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants