chore: add unit tests and cleanups (#913)

Changes:
- add signer checks unit tests
- add cpi context unit tests
- add cpi context associated Merkle tree check
- moved hash output compressed accounts and prepare append cpi instruction data into function
- removed dead code in hash input compressed accounts
- removed registered program pda type from anchor Instruction structs other than in account compression program

Author: ananas-block

cli/accounts/cpi_context_Bvux5m7rMGXJfjNCKUXHaRMcVJCiDe6iWu8ANj8kpwu5.json

@@ -95,7 +95,6 @@ pub fn process_escrow_compressed_tokens_with_compressed_pda<'info>(
         proof.clone(),
         cpi_context,
     )?;
-    msg!("escrow compressed tokens with compressed pda");
     cpi_compressed_pda_transfer(
         ctx,
         proof,

examples/token-escrow/programs/token-escrow/src/escrow_with_compressed_pda/escrow.rs

@@ -30,7 +30,7 @@ impl GroupAccess for StateMerkleTreeAccount {
         &self.metadata.access_metadata.owner
     }
 
-    fn get_delegate(&self) -> &Pubkey {
+    fn get_program_owner(&self) -> &Pubkey {
         &self.metadata.access_metadata.program_owner
     }
 }

programs/account-compression/src/config_accounts/mod.rs

@@ -59,10 +59,6 @@ pub fn process_initialize_address_merkle_tree_and_queue<'info>(
     merkle_tree_config: AddressMerkleTreeConfig,
     queue_config: AddressQueueConfig,
 ) -> Result<()> {
-    if merkle_tree_config.close_threshold.is_some() {
-        unimplemented!("Close threshold not supported.");
-    }
-
     let merkle_tree_rent = ctx.accounts.merkle_tree.get_lamports();
     process_initialize_address_queue(
         &ctx.accounts.queue.to_account_info(),

programs/account-compression/src/instructions/append_leaves.rs

@@ -1,6 +1,6 @@
 use anchor_lang::{prelude::*, solana_program::pubkey::Pubkey};
 
-use crate::{config_accounts::GroupAuthority, utils::constants::GROUP_AUTHORITY_SEED};
+use crate::{state::GroupAuthority, utils::constants::GROUP_AUTHORITY_SEED};
 
 #[derive(Accounts)]
 pub struct InitializeGroupAuthority<'info> {

programs/account-compression/src/instructions/initialize_address_merkle_tree_and_queue.rs

@@ -75,10 +75,6 @@ pub fn process_initialize_state_merkle_tree_and_nullifier_queue(
     nullifier_queue_config: NullifierQueueConfig,
     additional_rent: u64,
 ) -> Result<()> {
-    if state_merkle_tree_config.close_threshold.is_some() {
-        unimplemented!("Close threshold not supported.");
-    }
-
     process_initialize_state_merkle_tree(
         &ctx.accounts.merkle_tree,
         index,

programs/account-compression/src/instructions/initialize_group_authority.rs

@@ -27,13 +27,7 @@ pub struct InsertIntoQueues<'info> {
 /// Inserts every element into the indexed array.
 /// Throws an error if the element already exists.
 /// Expects an indexed queue account as for every index as remaining account.
-pub fn process_insert_into_queues<
-    'a,
-    'b,
-    'c: 'info,
-    'info,
-    MerkleTreeAccount: Owner + ZeroCopy, // SequenceNumber,
->(
+pub fn process_insert_into_queues<'a, 'b, 'c: 'info, 'info, MerkleTreeAccount: Owner + ZeroCopy>(
     ctx: Context<'a, 'b, 'c, 'info, InsertIntoQueues<'info>>,
     elements: &'a [[u8; 32]],
     queue_type: QueueType,

programs/account-compression/src/instructions/initialize_state_merkle_tree_and_nullifier_queue.rs

@@ -25,8 +25,8 @@ pub use update_group_authority::*;
 pub mod register_program;
 pub use register_program::*;
 
-pub mod rollover_state_merkle_tree;
-pub use rollover_state_merkle_tree::*;
+pub mod rollover_state_merkle_tree_and_queue;
+pub use rollover_state_merkle_tree_and_queue::*;
 
 pub mod rollover_address_merkle_tree_and_queue;
 pub use rollover_address_merkle_tree_and_queue::*;