Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hitting the max possible allocation size when U8 encoding with the custom gc #77

Closed
radkomih opened this issue Aug 31, 2023 · 0 comments · Fixed by #78
Closed

hitting the max possible allocation size when U8 encoding with the custom gc #77

radkomih opened this issue Aug 31, 2023 · 0 comments · Fixed by #78
Labels
bug Something isn't working

Comments

@radkomih
Copy link
Collaborator

Since U8 is used extensively, e.g. Sequence[U8], invoking value.Bytes() to return the bytes causes a significant performance overhead with the custom gc, and it tries to allocate single allocation bigger than the max possible.

func (value U8) Encode(buffer *bytes.Buffer) {
	encoder := Encoder{Writer: buffer}
	encoder.Write(value.Bytes())
}

func (value U8) Bytes() []byte {
	return []byte{byte(value)}
}

Instead encode the bytes directly

encoder.EncodeByte(byte(value))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant