Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run integration/benchmark tests for all available runtime templates #406

Open
1 task done
radkomih opened this issue Apr 19, 2024 · 0 comments
Open
1 task done

Comments

@radkomih
Copy link
Collaborator

radkomih commented Apr 19, 2024

Is there an existing issue?

  • I have searched the existing issues

Motivation

No response

Request

Currently integration tests (in runtime/, benchmarking/ folders) are executed only for the specified runtime template that is being built. It will be beneficial if we can build and run integration tests for all consensus engines (locally and in GitHub) to remove duplication and find issues early.

Solution

  1. Extract common tests that are not consensus-specific to a separate folder, such as runtime/common/ and consensus-specific should be respectively in runtime/poa/ and runtime/pos/. The benchmarking/ folder contains integration tests that currently work for a single consensus engine at a time and should be updated to work for all consensus engines (move all benchmark tests in one place, currently they are located in two different directories: /benchmarking and /runtime.).
  2. Build all templates (runtime/poa, runtime/pos).
  3. Run integration tests for all templates (same for the common benchmarks too).

Are you willing to help with this request?

Yes!

This was referenced Apr 19, 2024
@radkomih radkomih changed the title build and run integration tests for all available runtime templates run integration/benchmark tests for all available runtime templates Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant