Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve absolute references to the current fhir server similar to relative ones #1375

Closed
lmsurpre opened this issue Jul 29, 2020 · 4 comments

Comments

@lmsurpre
Copy link
Member

Is your feature request related to a problem? Please describe.
FHIR spec says that for a server at example.com, the following should be treated as equivalent:

<patient>
  <reference value="Patient/123"/>
</patient>
<patient>
  <reference value="http://example.org/fhir/Patient/123"/>
</patient>

Similarly, I think the following two search expressions should be equivalent:

Observation?patient=Patient/123
Observation?patient=http://example.org/fhir/Patient/123

Describe the solution you'd like
On the way in, we should detect absolute references to resources on the "current host" and normalize them to relative paths.

Describe alternatives you've considered
An alternative is to convert everything to an absolute URI, but thats a bigger departure from our status quo.

Additional context
Relates to discussions wrt enforcing referential integrity between resources.

@prb112
Copy link
Contributor

prb112 commented Oct 5, 2020

This may exist already in #300 please confirm and add a test for this case

@prb112 prb112 added this to the Sprint 19 milestone Oct 5, 2020
@prb112
Copy link
Contributor

prb112 commented Oct 5, 2020

Team discussion: sprint 19 since the work is done

@prb112
Copy link
Contributor

prb112 commented Oct 27, 2020

Moving to Review/QA.

@lmsurpre can you confirm? if not, move to Sprint 20

@lmsurpre
Copy link
Member Author

Robin confirmed that with #1604 then this one will be resolved. When the full URL matches the URL of the fhir server, we strip off the URL prefix and store just the relative reference.

@prb112 prb112 closed this as completed Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants