Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fhir-bucket reindex doc could use some helpful pointers #3272

Open
d0roppe opened this issue Feb 2, 2022 · 1 comment
Open

fhir-bucket reindex doc could use some helpful pointers #3272

d0roppe opened this issue Feb 2, 2022 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request P3 Priority 3 - Nice To Have

Comments

@d0roppe
Copy link
Collaborator

d0roppe commented Feb 2, 2022

Is your feature request related to a problem? Please describe.
when looking at the fhir-bucket doc there is nothing noted in the reindex section as to what the name of the jar file is. You can find it below in the other sections, but not in the reindex section that is first.

Also there is a mention of a logging.properties file, but no info on what should be in this file or where to find that information.

Also there is nothing that states that some of the server.properties values are required.

the sample file for server.properties has the entry

fhir.server.endpoint=/fhir-server/api/v4

For it to work it needs another '/' after the v4 like:

fhir.server.endpoint=/fhir-server/api/v4/

Describe the solution you'd like
updated documentation to make it more clear as to how to use.

Describe alternatives you've considered
for the fhir.server.endpoint=, the code could be changed to accommodate the setting passed.

Acceptance Criteria

Documentation has been updated to address the above issues noted.

Additional context
Add any other context or screenshots about the feature request here.

@d0roppe d0roppe added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 2, 2022
@lmsurpre
Copy link
Member

not sure if original concerns are already addressed or not, but we can also use this one to provide a better sample command for reindex... we don't need all those args listed at https://github.com/IBM/FHIR/tree/main/fhir-bucket#1-reindex---driving-the-reindex-custom-operation

@lmsurpre lmsurpre added the P3 Priority 3 - Nice To Have label Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request P3 Priority 3 - Nice To Have
Projects
None yet
Development

No branches or pull requests

2 participants