Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconciliation service for S3 / minio payload offload #3422

Open
lmsurpre opened this issue Mar 2, 2022 · 0 comments
Open

Reconciliation service for S3 / minio payload offload #3422

lmsurpre opened this issue Mar 2, 2022 · 0 comments
Labels
enhancement New feature or request P3 Priority 3 - Nice To Have

Comments

@lmsurpre
Copy link
Member

lmsurpre commented Mar 2, 2022

Is your feature request related to a problem? Please describe.
With payload-offloading, the call to store the payload is made before the RDBMS transaction commits. If the transaction is rolled back, an attempt is made to delete any payloads which were stored as part of the transaction. However, it is possible that the delete call could fail (a network partition, maybe) in which case resource records will exist in the offload store, but not the RDBMS.

Describe the solution you'd like
Make it work like the azure-blob one.

Should we have a single module / cli jar that handles both s3 / minio AND azure-blob? Or just copy the fhir-persistence-blob-app project to a new one named fhir-persistence-cos-app (or fhir-persistence-s3-app)?

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Acceptance Criteria

  1. GIVEN [a precondition]
    AND [another precondition]
    WHEN [test step]
    AND [test step]
    THEN [verification step]
    AND [verification step]

Additional context
Just like #3143 but for s3 / minio

@lmsurpre lmsurpre added the enhancement New feature or request label Mar 2, 2022
@lmsurpre lmsurpre added the P3 Priority 3 - Nice To Have label May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P3 Priority 3 - Nice To Have
Projects
None yet
Development

No branches or pull requests

1 participant