Issue #2365 - Show resource ids in conditional delete operation outcome #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
lmsurpre
reviewed
May 17, 2021
| @@ -2563,6 +2563,7 @@ Bundle createSearchBundle(List<Resource> resources, FHIRSearchContext searchCont | |||
| Entry.Builder entryBuilder = Entry.builder(); | |||
| if (resource != null) { | |||
| if (resource.getId() != null) { | |||
| entryBuilder.id(resource.getId()); | |||
There was a problem hiding this comment.
why are we using the Entry.id for this?
There was a problem hiding this comment.
I guess its because there is no resource in the response entries, and so we can't use the normal Entry.resource.id. Still, I think we might want a comment for this because using Entry.id for the id of the deleted resource is a bit unique.
There was a problem hiding this comment.
side-note: you definitely didn't introduce this idea of using the entry id for this. that comes from
FHIRRestHelper.doDelete near line 722:
responseBundle.getEntry().stream().map(Bundle.Entry::getId).collect(Collectors.joining(","))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2365 - Show resource ids in conditional delete operation outcome
Signed-off-by: Troy Biesterfeld tbieste@us.ibm.com