Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup takes forever #2

Open
1 task done
Lioness100 opened this issue Feb 6, 2023 · 4 comments
Open
1 task done

Startup takes forever #2

Lioness100 opened this issue Feb 6, 2023 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Lioness100
Copy link
Owner

Is there an existing issue for this?

  • I have searched the existing issues

Description of the bug

Just a simple rspell --help takes 25 seconds to respond, and I have no idea why. Any help on this would be appreciated.

Steps To Reproduce

rspell --help and time it :)

Screenshots

No response

Additional context

No response

@Lioness100 Lioness100 added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Feb 6, 2023
@ankits57
Copy link

ankits57 commented Feb 7, 2023

ok, I will be looking into this

@Lioness100
Copy link
Owner Author

Thanks so so much!!!

@Lioness100 Lioness100 reopened this Feb 9, 2023
@Lioness100
Copy link
Owner Author

The above commit didn't fix it, just made it a bit faster. All of the time loss is from requiring packages (you can use time-require for local testing). It looks like this isn't a problem when compiling to esm. The only reason I compiled to cjs is because pkg, used to compile the output into an executable file, can only handle cjs. So, we could have the files published to npm be esm, and the files used in the github action with pkg to be cjs, but then the executable files would suffer the same issue.

@Lioness100
Copy link
Owner Author

There's also the option of just stopping support for the precompiled binaries, they're really big anyways and were only supported as a little experiment. Not sure though, they may have some merit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants