Why is mem_round flushed twice while finishing a round

[sqfasd]

https://github.com/LiskHQ/lisk/blob/development/modules/round.js#L136
https://github.com/LiskHQ/lisk/blob/development/modules/round.js#L137

return this.updateVotes()
            .then(this.updateMissedBlocks)
            .then(this.flushRound)
            .then(this.applyRound)
            .then(this.updateVotes)
            .then(this.flushRound)
            .then(function () {
                private.ticking = false;
                return t;
            });

I think the later updateVotes and flushRound can be removed.

[karmacoma]

The current procedure is as follows:

• Update votes (from account balances)
• Update delegates which have missed blocks
• Flush the round
• Apply fees, rewards to eligible delegates
• Update votes (from account balances) - i.e. changed by fees, rewards
• Flush the round

Which could be changed to something like:

• Update delegates which have missed blocks
• Apply fees, rewards to eligible delegates
• Update votes (from account balances)
• Flush the round

Requires further implementation and testing.

[karmacoma]

Should be resolved after: #543 is closed.

[karmacoma]

Closed by: #597

[4miners]

Need recheck because #597 is reverted.

[diego-G]

It should be reviewed after #1303

[MaciejBaj]

Re-opened as the fix was inverted as part of #2420.

[MaciejBaj]

Can only be solved after #2423 is done, which is waiting for the next hard fork as breaking. Suspended for now.

[shuse2]

This will be addressed with part of the BFT implementation #3555