Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add missing unit test for AuthModule Hooks #7238

Closed
Tracked by #7208
has5aan opened this issue Jun 23, 2022 · 1 comment
Closed
Tracked by #7208

Add missing unit test for AuthModule Hooks #7238

has5aan opened this issue Jun 23, 2022 · 1 comment

Comments

@has5aan
Copy link
Contributor

has5aan commented Jun 23, 2022

AuthModule Hooks

Description

  • Test missing for AuthModule.beforeExecuteCommand(), it creates a new account if it doesn't exists using the address in the transaction. This is updated under Add missing unit tests for Auth module Hooks #7913
  • The expected functionality mentioned below has been covered by the changes made under Auth module improvements #7864.
    Test missing for AuthModule.verifyTransaction(), it creates a senderAccount if ImmutableSubStore.getWithSchema() throws NotFoundError. In reference to LIP 0041, Transaction.nonce is to be set to zero and transaction is to be validated.

Which version(s) does this affect? (Environment, OS, etc...)

Lisk SDK development branch.

@has5aan
Copy link
Contributor Author

has5aan commented Jan 4, 2023

This is resolved in #7864 and #7913.

@has5aan has5aan closed this as completed Jan 4, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Lisk SDK Version 6.0.0 Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants