Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add missing unit tests for the Random Module hooks #7822

Closed
Tracked by #7244
mosmartin opened this issue Nov 28, 2022 · 1 comment
Closed
Tracked by #7244

Add missing unit tests for the Random Module hooks #7822

mosmartin opened this issue Nov 28, 2022 · 1 comment
Assignees
Milestone

Comments

@mosmartin
Copy link
Contributor

mosmartin commented Nov 28, 2022

Description

Based on the defined test cases, the following tests are missing from the implemented unit tests.

  • For the element in the block assets property for the random module, if its seedReveal property is 20 bytes
    • Expectation: validation passes
  • For the element in the block assets property for the random module, if its seedReveal property is not 20 bytes
    • Expectation: block processing fails
  • check seedReveal property of block assets with isSeedValidInput internal function and update validatorReveals array accordingly
    • Expectation: validatorReveals array of the random state store is updated
    • Update the DEFAULT_MAX_LENGTH_REVEALS to MAX_LENGTH_VALIDATOR_REVEALS as defined in the LIP

Motivation

These test will align with defined test cases and ensure complete coverage of the scenarios.

@Madhulearn Madhulearn added this to the Sprint 85 milestone Dec 19, 2022
@Madhulearn Madhulearn modified the milestones: Sprint 85, Sprint 86 Jan 3, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 86, Sprint 87 Jan 17, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 87, Sprint 88 Jan 30, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 88, Sprint 89 Feb 13, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 89, Sprint 90 Feb 28, 2023
@shuse2 shuse2 removed this from the Sprint 90 milestone Mar 2, 2023
@Madhulearn Madhulearn added this to the Sprint 94 milestone Apr 24, 2023
@mosmartin
Copy link
Contributor Author

The first two tests are off. The test scenarios provided are incorrect.

The last issue is more cosmetic and does not impact the protocol but would be nice to align.

@mosmartin mosmartin self-assigned this May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants