Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Find all strings for i18n in modals - Closes #744 #763

Merged
merged 47 commits into from
Sep 29, 2017

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Sep 22, 2017

Closes #744

@slaweet slaweet force-pushed the 744-stings-i18n-modals branch from deaec52 to 914668f Compare September 22, 2017 09:50
@slaweet slaweet force-pushed the 744-stings-i18n-modals branch from 20a0beb to 00b04b8 Compare September 26, 2017 08:12
@slaweet slaweet force-pushed the 744-stings-i18n-modals branch from 09faf4e to 5f51ab1 Compare September 27, 2017 08:17
@reyraa
Copy link
Contributor

reyraa commented Sep 29, 2017

We have a navigate function which uses tabs arrays to navigate to tabs:

const navigate = (history, tabs, index) => {
  if (!isCurrent(history, index, tabs)) {
    history.push(`/main/${tabs[index].toLowerCase()}`);
  }
};

translating tabs items breaks the navigation since the route is not defined anymore. I think we have to use objects instead of string in this array:

const tabs = [
  {
    label: t('Transactions'),
    id: transactions,
  }, {
    label: t('Voting'),
    id: voting,
  }, {
    label: t('Forging'),
    id: forging,
 },
];

@reyraa
Copy link
Contributor

reyraa commented Sep 29, 2017

These translations are missing:

  • settings label in menu (This has the t function called but for some reason the script couldn't index it)
  • all the labels in votingBar
  • The description in forging for non-delegates

Copy link
Contributor

@reyraa reyraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vit. Great job!

@slaweet slaweet merged commit aa38811 into development Sep 29, 2017
@slaweet slaweet deleted the 744-stings-i18n-modals branch September 29, 2017 10:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants