This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Handle failed pending transactions - Closes #738 #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because the failed transactions is rarer than I thought and there is no easy way to reproduce it so that we can actually test it. This reverts commit ccedb70.
because the failed transactions is rarer than I thought and there is no easy way to reproduce it so that we can actually test it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the end, I implemented this exactly as described in #738. I discarded the idea with displaying the failed transactions in red because after discussing it with Isabella I found out that this situation is much less likely than I originally thought.
It is impossible to produce this situation with just one Lisk node - e.g. If I send two transactions with the total sum exceeding my balance, the second one is rejected right away and won't make it to the pending state.
Closes #738