Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEEDBACK] Apply all external stylesheets on top of current theme? #1000

Closed
changbowen opened this issue Dec 6, 2022 · 5 comments
Closed

Comments

@changbowen
Copy link

changbowen commented Dec 6, 2022

According to the theme select code, looks like only one of the external stylesheets can be selected at a time. I always assume all external style sheets are applied on top of the current theme by default. Maybe external stylesheets are meant to be used differently than I imagined.

But IMHO only being able to selecting one feels a bit strange because why keep a list of them when unwanted ones can just be removed from the config.. also all customizations need to be moved into a single CSS file if only one can be selected at a time.

This also means there is no way to use the external stylesheet with a non-default theme because once another theme is selected, the external stylesheet won't be in effect anymore after reload. This is a bit of a shame because some of the included themes are so beautiful :)


Update:
Found a quick and dirty way to always apply all external stylesheets, which is to comment out this line

@liss-bot
Copy link
Collaborator

liss-bot commented Dec 6, 2022

If you're enjoying Dashy, consider dropping us a ⭐
🤖 I'm a bot, and this message was automated

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Dec 6, 2022
@changbowen changbowen changed the title CSS files in externalStyleSheet doesn't get applied Apply all external stylesheets on top of current theme? Dec 6, 2022
@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Dec 7, 2022
@changbowen changbowen changed the title Apply all external stylesheets on top of current theme? [FEEDBACK] Apply all external stylesheets on top of current theme? Dec 8, 2022
@liss-bot
Copy link
Collaborator

liss-bot commented Jan 8, 2023

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Jan 8, 2023
@changbowen
Copy link
Author

still relevant

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed ⚰️ Stale [ISSUE] [PR] No activity for over 1 month labels Jan 8, 2023
@liss-bot
Copy link
Collaborator

liss-bot commented Feb 8, 2023

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added ⚰️ Stale [ISSUE] [PR] No activity for over 1 month and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Feb 8, 2023
@liss-bot
Copy link
Collaborator

This issue was automatically closed because it has been stalled for over 6 weeks with no activity.

@liss-bot liss-bot removed the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants