Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] startingView not working #646

Closed
4 tasks done
dominiwe opened this issue May 11, 2022 · 6 comments
Closed
4 tasks done

[BUG] startingView not working #646

dominiwe opened this issue May 11, 2022 · 6 comments
Assignees
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🔨 Fixed 🛩️ Released 2.0.9

Comments

@dominiwe
Copy link

dominiwe commented May 11, 2022

Environment

Self-Hosted (Docker)

Version

2.0.8

Describe the problem

Setting startingView in the config to minimal doesn't change anything.
Example:

appConfig:
  startingView: minimal

Additional info

I'm using Nginx as a reverse proxy to access the web services running in docker containers.

Please tick the boxes

@dominiwe dominiwe added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label May 11, 2022
@liss-bot

This comment was marked as outdated.

@dominiwe
Copy link
Author

@Lissy93 Probably closed because I only recently joined GitHub.

@Lissy93 Lissy93 reopened this May 11, 2022
@Lissy93
Copy link
Owner

Lissy93 commented May 11, 2022

I'll reopen...

Repository owner deleted a comment from liss-bot May 11, 2022
@dominiwe
Copy link
Author

dominiwe commented May 11, 2022

I made a typo, see response.

Building and running from source I see this:

Checking config file against schema...

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
  Warning: 1 issue found in config file
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
1. /appConfig must NOT have additional properties (startView)

Searching through the source I didn't find the term startView anywhere.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label May 11, 2022
@Lissy93
Copy link
Owner

Lissy93 commented May 11, 2022

That one is caused by a small typo, startView should be startingView ;)

But the original issue is correct, there's a bug in the router, where the config isn't read at time of initialization, causing it to fallback to defaults. I've got a fix ready, and will submit a PR when I get time, this week :)

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label May 11, 2022
@liss-bot
Copy link
Collaborator

The fix for this issue has now been released in 2.0.9 ✨

If you haven't done so already, please update your instance to 2.0.9 or later. See 2.0.9 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🔨 Fixed 🛩️ Released 2.0.9
Projects
None yet
Development

No branches or pull requests

3 participants