Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Config should have it own folder #902

Closed
5 tasks done
chevdor opened this issue Sep 12, 2022 · 4 comments
Closed
5 tasks done

[BUG] Config should have it own folder #902

chevdor opened this issue Sep 12, 2022 · 4 comments
Assignees
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🕸️ Inactive

Comments

@chevdor
Copy link

chevdor commented Sep 12, 2022

Environment

Self-Hosted (Docker)

System

n/a

Version

master

Describe the problem

Currently the config is a conf.yml file in `/app/public/.
That works fine for a single file config when using containers (docker, k8s, ..)

If however you have a config in multiple files, you will need to mount the entire /app/public folder for your container to see all config files and this will shadow the rest of the files under /app/public.

Ideally the config folder should be configurable or set to a subfolder somewhere. That could be /app/config by default for instance. This would allow mapping /app/config while not affecting the content of /app/public (also the config should probably not be public).

Additional info

No response

Please tick the boxes

@chevdor chevdor added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label Sep 12, 2022
@getuslocal
Copy link

Im having an issue with this as well. I bind the local to the hosted path but it forces me to put config.yml in the actual path (which makes no sense). I would expect to see /app/config/ and that is where the yml file is read from that way I can attach it to a volume etc. When you do /app/public/config.yml it actually creates a folder called config.yml with no config file in it, and when I added one it still didn't read or recognize it.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Sep 27, 2022
@Lissy93
Copy link
Owner

Lissy93 commented Sep 27, 2022

Have already implemented this as part of #799 - but am just waiting until the rest of the ticket is completed before it will be merged (for version 2.1.2)

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Sep 27, 2022
@liss-bot
Copy link
Collaborator

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Oct 28, 2022
@liss-bot
Copy link
Collaborator

liss-bot commented Nov 3, 2022

This issue was automatically closed because it has been stalled for over 6 weeks with no activity.

@liss-bot liss-bot closed this as completed Nov 3, 2022
@liss-bot liss-bot removed the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🕸️ Inactive
Projects
None yet
Development

No branches or pull requests

4 participants