Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Background based on Delta for the Timer #380

Closed
CryZe opened this issue Dec 30, 2020 · 3 comments · Fixed by #539
Closed

Implement Background based on Delta for the Timer #380

CryZe opened this issue Dec 30, 2020 · 3 comments · Fixed by #539
Labels
enhancement An improvement for livesplit-core. feature A new user visible feature for livesplit-core.

Comments

@CryZe
Copy link
Collaborator

CryZe commented Dec 30, 2020

I completely forgot that this is an actual feature. I noticed this when I tried to import some layout file that didn't parse correctly.

LiveSplit/LiveSplit.Timer@fbacda1

@CryZe CryZe added bug There is a bug. enhancement An improvement for livesplit-core. suitable for contributions The issue is suitable those who are contributing to livesplit-core. feature A new user visible feature for livesplit-core. labels Dec 30, 2020
@CryZe CryZe removed the bug There is a bug. label Feb 7, 2021
@Hurricane996
Copy link
Contributor

ok im messing with this. I'm trying to figure out how to represent delta gradient as a setting. It seems like the best option is to add another variant of Value, but that's a breaking change. Please advise

@CryZe
Copy link
Collaborator Author

CryZe commented Jun 6, 2022

Breaking changes are totally fine at this point 👍

@Hurricane996
Copy link
Contributor

I noticed something interesting while I was fixing the alpha; vanilla livesplit doesn't consider the timer's background color at all. The gradient just goes from very transparent, devalued, desaturated version of the delta color to a more natrual version. Is that intended behavior?

@CryZe CryZe closed this as completed in #539 Aug 5, 2022
@CryZe CryZe removed the suitable for contributions The issue is suitable those who are contributing to livesplit-core. label Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement for livesplit-core. feature A new user visible feature for livesplit-core.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants