Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the renderer more stateful #389

Closed
CryZe opened this issue Jan 13, 2021 · 0 comments · Fixed by #430
Closed

Make the renderer more stateful #389

CryZe opened this issue Jan 13, 2021 · 0 comments · Fixed by #430
Labels
enhancement An improvement for livesplit-core. performance Affects the performance of the code. priority: high This is a high priority issue. rendering The issue or pull request is affecting the rendering.

Comments

@CryZe
Copy link
Collaborator

CryZe commented Jan 13, 2021

The renderer currently has no real persistent notion of components and positioned elements inside them. This means that we have to lay out all the glyphs and other elements every frame which is quite expensive. Additionally this also forces the underlying backend to have to rerender everything every frame. We should implement a React like diffing model that stores and updates an underlying stateful tree.

@CryZe CryZe added enhancement An improvement for livesplit-core. rendering The issue or pull request is affecting the rendering. priority: high This is a high priority issue. performance Affects the performance of the code. labels Jan 13, 2021
@CryZe CryZe linked a pull request Jun 8, 2021 that will close this issue
@CryZe CryZe closed this as completed in #430 Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement for livesplit-core. performance Affects the performance of the code. priority: high This is a high priority issue. rendering The issue or pull request is affecting the rendering.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant