Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge KeyCode enums into a single cross-platform one #423

Closed
CryZe opened this issue Apr 10, 2021 · 0 comments · Fixed by #440
Closed

Merge KeyCode enums into a single cross-platform one #423

CryZe opened this issue Apr 10, 2021 · 0 comments · Fixed by #440
Labels
code quality Affects the quality of the code. hotkey This is about the hotkey implementation. suitable for contributions The issue is suitable those who are contributing to livesplit-core.

Comments

@CryZe
Copy link
Collaborator

CryZe commented Apr 10, 2021

At the moment the livesplit-hotkey library exposes a platform specific KeyCode enum. This however is not only a lot of duplication, but also the variants are inconsistently named, so actually matching on a key code or specifying one in your code is not as portable as you would like it to be.
@CryZe CryZe added suitable for contributions The issue is suitable those who are contributing to livesplit-core. code quality Affects the quality of the code. hotkey This is about the hotkey implementation. labels Apr 10, 2021
@CryZe CryZe added the work in progress Someone is working on this. label Jul 25, 2021
@CryZe CryZe mentioned this issue Jul 26, 2021
Merged
@CryZe CryZe removed the work in progress Someone is working on this. label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Affects the quality of the code. hotkey This is about the hotkey implementation. suitable for contributions The issue is suitable those who are contributing to livesplit-core.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce a single cross-platform KeyCode enum CryZe/livesplit-core
1 participant
@CryZe