Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable Text Engine Support #491

Closed
CryZe opened this issue Dec 19, 2021 · 0 comments · Fixed by #495
Closed

Customizable Text Engine Support #491

CryZe opened this issue Dec 19, 2021 · 0 comments · Fixed by #495
Labels
enhancement An improvement for livesplit-core. feature A new user visible feature for livesplit-core. priority: high This is a high priority issue. rendering The issue or pull request is affecting the rendering. text engine This is about the text engine implementation.

Comments

@CryZe
Copy link
Collaborator

CryZe commented Dec 19, 2021

Currently we bring our own text engine that always turns the glyphs into paths. This isn't ideal when using a rendering backend that itself supports rendering text. In the browser it's much better to let the canvas render out the text as that results in fewer draw calls and also allows using any fonts other than our default fonts in the first place as the browser does not allow getting access to the font data of the fonts installed on the user's system. Additionally our current text engine does not support any font fallback, so using the underlying renderer's or even the system's default text engine provides much better font fallback support. So for all of these reasons and more it would be ideal to be able to swap out the text engine.

This actually is already mostly implemented.

@CryZe CryZe added enhancement An improvement for livesplit-core. rendering The issue or pull request is affecting the rendering. work in progress Someone is working on this. feature A new user visible feature for livesplit-core. priority: high This is a high priority issue. labels Dec 19, 2021
@CryZe CryZe added text engine This is about the text engine implementation. and removed work in progress Someone is working on this. labels Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement for livesplit-core. feature A new user visible feature for livesplit-core. priority: high This is a high priority issue. rendering The issue or pull request is affecting the rendering. text engine This is about the text engine implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant