Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust splits column width based on the current font #492

Closed
CryZe opened this issue Dec 19, 2021 · 2 comments · Fixed by #550
Closed

Adjust splits column width based on the current font #492

CryZe opened this issue Dec 19, 2021 · 2 comments · Fixed by #550
Labels
enhancement An improvement for livesplit-core. feature A new user visible feature for livesplit-core. priority: high This is a high priority issue. rendering The issue or pull request is affecting the rendering. suitable for contributions The issue is suitable those who are contributing to livesplit-core.

Comments

@CryZe
Copy link
Collaborator

CryZe commented Dec 19, 2021

In the original LiveSplit we measure the width of 88:88:88 I believe and use that as the column width. We should do something similar here instead of hardcoding a width.

@CryZe CryZe added enhancement An improvement for livesplit-core. suitable for contributions The issue is suitable those who are contributing to livesplit-core. rendering The issue or pull request is affecting the rendering. feature A new user visible feature for livesplit-core. priority: high This is a high priority issue. labels Dec 19, 2021
@kadiwa4
Copy link
Contributor

kadiwa4 commented Dec 29, 2021

LiveSplit uses 9:00:00 for deltas and 24:00:00 otherwise (source).
Would this require a new function on ResourceAllocator just for querying the width of a given string? Or should it be even more specific and take the number of digits/colons as function arguments?

@CryZe
Copy link
Collaborator Author

CryZe commented Dec 29, 2021

Nah, I'd say the splits simply should have labels for these around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement for livesplit-core. feature A new user visible feature for livesplit-core. priority: high This is a high priority issue. rendering The issue or pull request is affecting the rendering. suitable for contributions The issue is suitable those who are contributing to livesplit-core.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants