Yabai scripting additions are not reloaded after defaults are applied and Dock is restarted

[veselyn]

I've been experiencing that after rebuild, I cannot use Yabai features that require scripting additions until I manually load them with sudo yabai --load-sa.

From my quick debug session I've noted that:

• The scripting additions are loaded via a launchd daemon:

  nix-darwin/modules/services/yabai/default.nix

  Lines 93 to 97 in a35b08d

  	launchd.daemons.yabai-sa = {
  	script = "${cfg.package}/bin/yabai --load-sa";
  	serviceConfig.RunAtLoad = true;
  	serviceConfig.KeepAlive.SuccessfulExit = false;
  	};

• The Dock gets restarted when defaults are applied here:

  nix-darwin/modules/system/defaults-write.nix

  Lines 124 to 130 in a35b08d

  	${optionalString (length dock > 0) ''
  	# Only restart Dock if current user is logged in
  	if pgrep -xu $UID Dock >/dev/null; then
  	echo >&2 "restarting Dock..."
  	killall Dock || true
  	fi
  	''}

• The order of the activation scripts is correct (defaults are applied before launchd services are configured):

  nix-darwin/modules/system/activation-scripts.nix

  Lines 65 to 66 in a35b08d

  	${cfg.activationScripts.defaults.text}
  	${cfg.activationScripts.launchd.text}

• The launchd daemon is loaded only when it is different from the current applied one:

  nix-darwin/modules/system/launchd.nix

  Lines 18 to 32 in a35b08d

  	launchdActivation = basedir: target: ''
  	if ! diff '${cfg.build.launchd}/Library/${basedir}/${target}' '/Library/${basedir}/${target}' &> /dev/null; then
  	if test -f '/Library/${basedir}/${target}'; then
  	echo "reloading service $(basename ${target} .plist)" >&2
  	launchctl unload '/Library/${basedir}/${target}' || true
  	else
  	echo "creating service $(basename ${target} .plist)" >&2
  	fi
  	if test -L '/Library/${basedir}/${target}'; then
  	rm '/Library/${basedir}/${target}'
  	fi
  	cp -f '${cfg.build.launchd}/Library/${basedir}/${target}' '/Library/${basedir}/${target}'
  	launchctl load -w '/Library/${basedir}/${target}'
  	fi
  	'';

Therefore, unless there are changes to the launchd daemon, it will not run again and inject the scripting additions in the newly started Dock process.