-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In NuGet publish workflow, restrict valid versions to vM.N.O or vM.N.O-alpha.X.[issue-code] (OSOE-536) #187
Comments
Related: #70 This is kind of a duplicate, but not exactly, because generating the version number is (and should be) optional, because this pattern doesn't fit a production release number. |
Kind of, yes. But typos in version number keep happening and they sometimes break the upgrade process of freshly versioned packages, because the mistyped version keeps appearing at the top, for example, when actually a newer one exists. |
This happened again now: https://github.com/Lombiq/Orchard-Privacy/pull/50/files#diff-0cb3d0d3e8c6b5787f70f48b2d467b21fc55ef86f64fb8a3d13398f414a8271aR54. I think it would be really easy to add a regex check to the version number for the time being, before someone will tackle and solve the much harder issue #70. |
@0liver, if the regex check's result is false, so the version number is incorrect, should the action just simply exit or what's the expected behavior? |
It should error out so that the responsible developer can fix the version. Best would be to add the expected format to the error message right away. |
Thank you. |
@0liver I already tested my code locally, but is it possible to test the workflow with the new condition somewhere? |
You can use any of the NuGet-published modules in OSOCE to push new tags out which will generate new versions of a package, e.g. Node.js Extensions. Simply create a new tag at a commit and push that to GitHub. You'll have to point the repo's publish workflow at this issue's branch, of course. |
Jira issue
The text was updated successfully, but these errors were encountered: