Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate Orchard Core extension manifest version number update during NuGet publish (OSOE-86) #4

Closed
Piedone opened this issue Mar 9, 2022 · 0 comments · Fixed by #8
Labels
enhancement New feature or request

Comments

@Piedone
Copy link
Member

Piedone commented Mar 9, 2022

When we publish a new NuGet package for OC extensions, we have to maintain Version in the extension manifest manually. This is not just necessary for when we use the extension from NuGet, but also when using it as a submodule. Thus, it's not trivial, since we can't just update the manifest for the NuGet publish but also need to do that in the repository.

But! Perhaps we don' actually need to keep manifest changes in the code; after all, it's mostly us who use the projects as submodules, and even if not, those users have the repo history at their fingertips. So, if the above is too complicated, we could get away with just setting the assembly version (what the build sets) as the manifest version. In this case, we should change all the version numbers in the Manifests to the default (when generated with the CLI template).

@Piedone Piedone added the enhancement New feature or request label Mar 9, 2022
@Piedone Piedone changed the title Automate Orchard Core extension manifest version number update during NuGet publish Automate Orchard Core extension manifest version number update during NuGet publish (OSOE-86) Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant