-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect behavior for fetch_nwb in Linearized position tables #912
Comments
Correction: Is not specific to the Linearized Position pipeline. |
Checking prior versions, error was introduced in #898 |
Got it. Removing this line in #898 caused the later projection in this file to not capture the relevant object id's Also, not forcing return as dict here causes the returned structure from Edit: wrt second point. forcing return dict as true is necessary for current implementations of |
@CBroz1 actually introduced those changes in a different PR. I just copied them over. |
👍 I made a pr that gets it working on the master branch again at #913. Once Chris has a chance to check it doesn't affect new features can merge it in |
Describe the bug
LinearizedPositionV1.fetch_nwb()
andIntervalLinearizedPosition.fetch_nwb()
return a string of the absolute path of the analysis file rather than an open nwb objectfetch1_dataframe()
for these tablesTo Reproduce
Both of these return an array of strings rather than open files
The text was updated successfully, but these errors were encountered: