Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window controls broken in FF133 when sidebery tweak active (hide-tabs-bar.css) #8

Open
alixyz-1 opened this issue Dec 1, 2024 · 7 comments

Comments

@alixyz-1
Copy link

alixyz-1 commented Dec 1, 2024

Window controls (minimise, maximise, and close) do not function when sidebery sidebar is open and tweak enabled to hide top tab bar.

It looks like an issue with hide-tabs-bar.css as per this comment in the "main" repo for EdgyArc-fr: artsyfriedchicken#85 (comment)

  • OS: Manjaro Linux
  • Desktop: KDE Plasma 6.2.4
  • Windowing system: Wayland
  • Browser version: Firefox 133
@Loskir
Copy link
Owner

Loskir commented Dec 3, 2024

Hello! Could you share your config? Can't seem to reproduce

@alixyz-1
Copy link
Author

alixyz-1 commented Dec 3, 2024

Hi, thanks for the reply. I've copied the chrome folder fresh from the git repo just now on a new profile (with no tweaks enabled) and it's happening still (FF 133.0). Not sure if it might be a linux/plasma/wayland only bug, although I'm not sure what system you're running.

@Loskir
Copy link
Owner

Loskir commented Dec 4, 2024

I'm running macos currently. Can you make a video with the problem?

@alixyz-1
Copy link
Author

alixyz-1 commented Dec 4, 2024

I've screen recorded the windows, and found something interesting. I noticed that I was able to select the window controls a little bit under where they actually are, however this only works for the close button when no other elements are in the "bookmarks bar" below it. When something is below the other window control buttons, they are able to be activated. A smaller item (i.e. fullscreen) only allowed the maximise button to be selected, while a wider one (copy/paste controls) allowed all to be activated when clicking below. I've attached 3 videos showing this here:

Screencast_20241204_174115.webm
Screencast_20241204_173602.webm
Screencast_20241204_173654.webm

@SJ50
Copy link

SJ50 commented Dec 6, 2024

Same issue in windows 11.
I can not select buttons like shown in above videos.

@craftycorvid
Copy link

Replacing hide-tabs-bar.css with the version from edge-frfox fixes the issue for me: https://github.com/bmFtZQ/edge-frfox/blob/main/chrome/tweaks/hide-tabs-bar.css

@craftycorvid
Copy link

craftycorvid commented Dec 11, 2024

There's another issue with the nav-bar in Windows when edge-sidebar is enabled. This filter in edge-sidebar.css gets applied twice to it, so it looks darker than the rest of the UI.

  #main-window::after,
  #browser::before {
    content: "";
    display: block;
    position: absolute;
    top: 0;
    right: 0;
    bottom: 0;
    left: 0;
    pointer-events: none;
    background-color: light-dark(#cdcdcd, #444) !important;
    opacity: 0.3;
  }

image

Deleting #main-window::after, fixes it, but I don't know if that's a universal solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants